Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated legacy color names #1526

Merged
merged 5 commits into from
Apr 12, 2022
Merged

Remove deprecated legacy color names #1526

merged 5 commits into from
Apr 12, 2022

Conversation

amelako
Copy link
Contributor

@amelako amelako commented Apr 12, 2022 •
edited
Loading

Purpose

Remove the deprecated legacy color names (success, warning and danger)

Approach and changes

  • remove the deprecated success, warning and danger color names

  • replace its use in the Body and Badge components

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@sumup-clark
Copy link

sumup-clark bot commented Apr 12, 2022

Hey @amelako,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 46fc10c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/design-tokens Major
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 12, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/2PYSAti3Q6rHoMCaXLJbcM6U5gVX
✅ Preview: https://oss-circuit-ui-git-remove-legacy-color-names.sumup-vercel.app

@amelako amelako changed the base branch from main to canary April 12, 2022 10:17
@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #1526 (46fc10c) into canary (2987be2) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #1526      +/-   ##
==========================================
+ Coverage   92.52%   92.61%   +0.08%     
==========================================
  Files         197      197              
  Lines        4134     4076      -58     
  Branches     1273     1239      -34     
==========================================
- Hits         3825     3775      -50     
+ Misses        290      282       -8     
  Partials       19       19
Impacted Files Coverage Δ
packages/circuit-ui/components/Badge/Badge.tsx 100.00% <ø> (+6.97%) ⬆️
packages/circuit-ui/components/Body/Body.tsx 97.29% <ø> (+2.85%) ⬆️
...ages/circuit-ui/components/BodyLarge/BodyLarge.tsx 100.00% <ø> (+4.44%) ⬆️
packages/design-tokens/themes/light.ts 0.00% <ø> (ø)
packages/design-tokens/utils/theme-prop-type.ts 0.00% <ø> (ø)
...mponents/NotificationBanner/NotificationBanner.tsx 83.60% <0.00%> (+1.63%) ⬆️

@amelako amelako marked this pull request as ready for review April 12, 2022 10:59
@amelako amelako requested a review from a team as a code owner April 12, 2022 10:59
@amelako amelako requested review from robinmetral and removed request for a team April 12, 2022 10:59
robinmetral
robinmetral reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

connor-baer
connor-baer approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add to Robin's comments.

robinmetral
robinmetral approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹✨

@amelako amelako merged commit ba05982 into canary Apr 12, 2022
@amelako amelako deleted the remove-legacy-color-names branch April 12, 2022 12:48
@github-actions github-actions bot mentioned this pull request Apr 12, 2022
Merged
This was referenced May 4, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor-baer connor-baer connor-baer approved these changes

@robinmetral robinmetral robinmetral approved these changes

Assignees
No one assigned
Labels
🗂 circuit-ui 🗂 design-tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amelako @connor-baer @robinmetral